Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1671] Dataset locks: always warn #1477

Merged
merged 2 commits into from
Feb 7, 2022
Merged

[AL-1671] Dataset locks: always warn #1477

merged 2 commits into from
Feb 7, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1477 (bef51b5) into main (250fbae) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
- Coverage   91.69%   91.65%   -0.04%     
==========================================
  Files         179      180       +1     
  Lines       14910    14903       -7     
==========================================
- Hits        13671    13660      -11     
- Misses       1239     1243       +4     
Flag Coverage Δ
unittests 91.65% <87.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/dataset/dataset.py 93.41% <66.66%> (-0.13%) ⬇️
hub/util/warnings.py 100.00% <100.00%> (ø)
hub/core/compute/provider.py 94.44% <0.00%> (-2.86%) ⬇️
hub/core/storage/s3.py 62.38% <0.00%> (-1.77%) ⬇️
hub/core/meta/encode/chunk_id.py 95.93% <0.00%> (-0.82%) ⬇️
hub/tests/path_fixtures.py 92.10% <0.00%> (-0.53%) ⬇️
hub/core/compression.py 85.27% <0.00%> (-0.12%) ⬇️
hub/core/query/filter.py 87.30% <0.00%> (-0.06%) ⬇️
hub/__init__.py 97.82% <0.00%> (-0.05%) ⬇️
hub/integrations/pytorch/dataset.py 91.30% <0.00%> (-0.04%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250fbae...bef51b5. Read the comment docs.

@farizrahman4u farizrahman4u merged commit 234b74b into main Feb 7, 2022
@farizrahman4u farizrahman4u deleted the fr_warn_always branch February 7, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants