Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1606] Reduce autocommits before checkout #1485

Merged
merged 69 commits into from
Feb 15, 2022
Merged

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Changes the logic of auto committing to consider the changes present in the head before checkout
  • Need to add tests

@AbhinavTuli AbhinavTuli changed the base branch from main to remove/cachable February 10, 2022 15:47
farizrahman4u
farizrahman4u previously approved these changes Feb 14, 2022
@farizrahman4u farizrahman4u dismissed their stale review February 14, 2022 13:01

Pickling issue on windows should be fixed.

Base automatically changed from remove/cachable to main February 15, 2022 06:16
@AbhinavTuli AbhinavTuli merged commit 95fbf8a into main Feb 15, 2022
@AbhinavTuli AbhinavTuli deleted the reduce/autocommits branch February 15, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants