Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-[1616] Tensorflow API Design #1530

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Mar 10, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@levongh levongh changed the title Tensorflow API Design AL-[1616] Tensorflow API Design Mar 10, 2022
@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 10, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1530 (93e21fe) into main (b7b83b8) will decrease coverage by 0.09%.
The diff coverage is 75.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   92.23%   92.13%   -0.10%     
==========================================
  Files         191      193       +2     
  Lines       16902    17029     +127     
==========================================
+ Hits        15589    15690     +101     
- Misses       1313     1339      +26     
Flag Coverage Δ
unittests 92.13% <75.21%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/integrations/tf/hubtensorflowdataset.py 74.10% <74.10%> (ø)
hub/integrations/__init__.py 100.00% <100.00%> (ø)
hub/integrations/tf/__init__.py 100.00% <100.00%> (ø)
hub/integrations/tf/datasettotensorflow.py 59.37% <100.00%> (ø)
hub/core/ipc.py 0.00% <0.00%> (ø)
hub/integrations/pytorch/dataset.py 91.37% <0.00%> (+0.03%) ⬆️
hub/core/query/filter.py 87.79% <0.00%> (+0.04%) ⬆️
hub/core/lock.py 89.47% <0.00%> (+0.06%) ⬆️
hub/core/compression.py 87.75% <0.00%> (+0.11%) ⬆️
hub/__init__.py 93.87% <0.00%> (+0.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b83b8...93e21fe. Read the comment docs.

@levongh levongh assigned levongh and unassigned levongh Mar 10, 2022
@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 10, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 10, 2022
@staticmethod
@hub_tf_adapter
def zip(datasets):
return tf.data.Dataset.zip(datasets)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is super used in some methods and tf.data.Dataset? let's use super everywhere?

@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@levongh levongh merged commit 220f828 into activeloopai:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants