Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-[1714] Add ResponseStreamingError to list of retry exceptions #1540

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Mar 14, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1540 (f9833ce) into main (a1a4693) will increase coverage by 0.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1540      +/-   ##
==========================================
+ Coverage   92.23%   92.29%   +0.05%     
==========================================
  Files         194      194              
  Lines       17190    17195       +5     
==========================================
+ Hits        15856    15870      +14     
+ Misses       1334     1325       -9     
Flag Coverage Δ
unittests 92.29% <60.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/storage/s3.py 66.79% <60.00%> (-0.14%) ⬇️
hub/core/dataset/dataset.py 93.27% <0.00%> (+0.38%) ⬆️
hub/core/lock.py 94.73% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a4693...f9833ce. Read the comment docs.

Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not update boto3 version, instead, we should try importing ResponseStreamingError and if it's not present in the version we can skip it

@levongh levongh merged commit 6d6a75c into main Mar 18, 2022
@levongh levongh deleted the al-1714 branch March 18, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants