Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mention for 100+ datasets & fixes #1568

Merged
merged 2 commits into from
Mar 31, 2022
Merged

added mention for 100+ datasets & fixes #1568

merged 2 commits into from
Mar 31, 2022

Conversation

mikayelh
Copy link
Collaborator

fixed some hyperlinks and added the mention of 100+ datasets we've just hit!

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

 fixed some hyperlinks and added the mention of 100+ datasets we've just hit!
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1568 (d248cc1) into main (536aa88) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head d248cc1 differs from pull request most recent head a8aba21. Consider uploading reports for the commit a8aba21 to get more accurate results

@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
+ Coverage   92.37%   92.44%   +0.07%     
==========================================
  Files         200      200              
  Lines       17984    17984              
==========================================
+ Hits        16613    16626      +13     
+ Misses       1371     1358      -13     
Flag Coverage Δ
unittests 92.44% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/dataset.py 90.86% <0.00%> (-0.54%) ⬇️
hub/util/exceptions.py 81.42% <0.00%> (+0.30%) ⬆️
hub/tests/path_fixtures.py 91.47% <0.00%> (+0.89%) ⬆️
hub/core/lock.py 92.10% <0.00%> (+2.63%) ⬆️
hub/client/utils.py 74.64% <0.00%> (+9.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536aa88...a8aba21. Read the comment docs.

Copy link
Contributor

@istranic istranic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikayelh Instead of "100+ pre-loaded datasets available in seconds" I would say

"100+ most-popular datasets available in seconds"

pre-loaded can be interpreted in all sorts of incorrect ways.

@mikayelh
Copy link
Collaborator Author

@istranic , agreed and fixed!

@mikayelh mikayelh requested a review from istranic March 31, 2022 06:12
@tatevikh tatevikh merged commit a50cc6e into main Mar 31, 2022
@tatevikh tatevikh deleted the mikayelh-patch-1-1 branch March 31, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants