-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prettytable package code with licence #1589
Added prettytable package code with licence #1589
Conversation
@davidbuniat I have added PrettyTable code to the hub. If this is merged, I can push the code to the pretty print issue. Tagging @farizrahman4u @mikayelh |
Sorry but this issue has already been addressed by #1543 . |
@farizrahman4u This PR aims to solve the issues @davidbuniat has mentioned here. |
@SaiNikhileshReddy I would still prefer @neel2299 's implementation as it does not add any additional dependencies nor does it copy the entire codebase of a library to hub repo (which is really bad for a simple feature like this). API wise, |
@farizrahman4u Thanks for sharing the feedback and @neel2299 implementation is good. I was aware of dependencies issues with external packages, but I was thinking in different perspective of having pandas like table generation which supports jupyter dataframe and even cli appearance without uisng external package within hub. I contacted @davidbuniat about this and he asked me to integrate the code from the PrettyTable package as there were no dependencies to their implementation and the licence supports code modification. It is my bad that I tried to add entire code instead of stripping unnecessary code for using internally in hub. I didn't want to reinvent the wheel again to generate table. The implementation I was trying to do was having flexibility in generating tables for both overall dataset and for each tensor without calling I'll probably work on Once again thanks for helping out. @farizrahman4u @mikayelh @davidbuniat |
@SaiNikhileshReddy I do not understand the "without calling |
Yes, we can integrate |
I wanted to make it simpler for anyone working with tables in the future with standard API internally in the hub. My main motivation for doing this was that @davidbuniat had mentioned in the issue to learn how pandas are implemented and try to source code for the hub. Instead of reinventing the table generation for quick completion of the problem. |
As now the problem has been solved, I'll try to push the code for Thanks for valuable feedback : ) |
馃殌 馃殌 Pull Request
Checklist:
coverage-rate
upChanges
I have added Pretty Table package to the hub by copying and adding licence to hub files. This package is being added directly into hub is to reduce package count and help this issue effectively.