Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to dataloader to make it more consistent with Pytorch loader #2160

Merged
merged 1 commit into from Feb 6, 2023

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 88.29% // Head: 88.28% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2136dd8) compared to base (40a2c60).
Patch coverage: 64.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
- Coverage   88.29%   88.28%   -0.01%     
==========================================
  Files         291      291              
  Lines       32049    32092      +43     
==========================================
+ Hits        28299    28334      +35     
- Misses       3750     3758       +8     
Flag Coverage Δ
unittests 88.28% <64.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/enterprise/dataloader.py 27.04% <64.28%> (+4.82%) ⬆️
deeplake/core/ipc.py 23.21% <0.00%> (-0.64%) ⬇️
deeplake/core/compression.py 80.84% <0.00%> (-0.14%) ⬇️
deeplake/core/chunk/chunk_compressed_chunk.py 92.70% <0.00%> (+0.03%) ⬆️
deeplake/__init__.py 95.08% <0.00%> (+0.08%) ⬆️
deeplake/integrations/pytorch/dataset.py 77.06% <0.00%> (+0.08%) ⬆️
deeplake/core/query/filter.py 78.90% <0.00%> (+0.08%) ⬆️
deeplake/core/lock.py 84.00% <0.00%> (+0.09%) ⬆️
deeplake/tests/path_fixtures.py 91.57% <0.00%> (+0.36%) ⬆️
deeplake/core/meta/encode/chunk_id.py 93.29% <0.00%> (+0.60%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AbhinavTuli AbhinavTuli merged commit 529b962 into main Feb 6, 2023
@AbhinavTuli AbhinavTuli deleted the dataloader_args branch February 6, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants