Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

View updates #2259

Merged
merged 5 commits into from
Mar 28, 2023
Merged

View updates #2259

merged 5 commits into from
Mar 28, 2023

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Mar 27, 2023

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • get_views() returns all views from all commits
  • view = ds.load_view(...) doesnt auto checkout ds
  • view.is_optimized property
  • Show commit_id in get_views()

deeplake/core/storage/memory.py Show resolved Hide resolved
@@ -3185,18 +3182,15 @@ def load_view(
Raises:
KeyError: if view with given id does not exist.
"""
view = self.get_view(id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farizrahman4u I tested the code and it works, but why is this function not running infinitely, since it's running recursively with no offramp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_view and get_view are different methods. There is no recursion.

deeplake/core/dataset/dataset.py Show resolved Hide resolved
@farizrahman4u farizrahman4u merged commit baeeee4 into main Mar 28, 2023
@farizrahman4u farizrahman4u deleted the fr_mp_updates branch March 28, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants