Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with ds.connect #2374

Merged
merged 2 commits into from
May 26, 2023
Merged

fix issue with ds.connect #2374

merged 2 commits into from
May 26, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented May 24, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2bfa3a2) 84.70% compared to head (45112ae) 84.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         323      323           
  Lines       36536    36551   +15     
=======================================
+ Hits        30946    30960   +14     
- Misses       5590     5591    +1     
Flag Coverage Δ
unittests 84.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/core/dataset/dataset.py 91.49% <100.00%> (+0.01%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@levongh levongh added the trigger-test Label trigger to run tests on PRs label May 25, 2023
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label May 25, 2023
@@ -3826,6 +3826,10 @@ def connect(
self._load_link_creds()
self._first_load_init(verbose=False)

next_storage = self.storage.next_storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use from deeplake.util.remove_cache import get_base_storage to get the base storage

@levongh levongh merged commit cedfd72 into main May 26, 2023
11 of 15 checks passed
@levongh levongh deleted the fix_s3_ds_used_creds branch May 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants