Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2298] Fix bugs with None samples #2382

Merged
merged 2 commits into from
Jun 1, 2023
Merged

[AL-2298] Fix bugs with None samples #2382

merged 2 commits into from
Jun 1, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@adolkhan
Copy link
Contributor

adolkhan commented May 29, 2023

was this throwing an error before if samples were none? If yes, can you pls add some tests?

@adolkhan adolkhan self-requested a review May 29, 2023 12:59
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (d721775) 84.71% compared to head (415aebc) 84.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
+ Coverage   84.71%   84.75%   +0.04%     
==========================================
  Files         323      323              
  Lines       36569    36591      +22     
==========================================
+ Hits        30980    31014      +34     
+ Misses       5589     5577      -12     
Flag Coverage Δ
unittests 84.75% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/util/casting.py 88.31% <ø> (ø)
deeplake/api/tests/test_none.py 100.00% <100.00%> (ø)
deeplake/core/chunk_engine.py 92.90% <100.00%> (+0.18%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FayazRahman FayazRahman merged commit e50bb2b into main Jun 1, 2023
9 of 15 checks passed
@FayazRahman FayazRahman deleted the fy_fix_none branch June 1, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants