Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2303] Rechunk fix for JSON #2421

Merged
merged 2 commits into from
Jun 9, 2023
Merged

[AL-2303] Rechunk fix for JSON #2421

merged 2 commits into from
Jun 9, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Fix serialization of sample in rechunk for text, json and list htypes

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f6d7f66). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 43c3b94 differs from pull request most recent head 1e88071. Consider uploading reports for the commit 1e88071 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2421   +/-   ##
=======================================
  Coverage        ?   84.68%           
=======================================
  Files           ?      326           
  Lines           ?    37567           
  Branches        ?        0           
=======================================
  Hits            ?    31814           
  Misses          ?     5753           
  Partials        ?        0           
Flag Coverage Δ
unittests 84.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/api/tests/test_rechunk.py 100.00% <100.00%> (ø)
deeplake/core/chunk_engine.py 93.77% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FayazRahman FayazRahman merged commit ec64b4d into main Jun 9, 2023
5 of 11 checks passed
@FayazRahman FayazRahman deleted the fy_fix_rechunk branch June 9, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants