-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VectorStore bug fixes #2441
VectorStore bug fixes #2441
Conversation
@@ -89,6 +89,11 @@ def parse_search_args(**kwargs): | |||
"Invalid `exec_option` it should be either `python`, `compute_engine` or `tensor_db`." | |||
) | |||
|
|||
if kwargs["embedding"] is not None and kwargs["query"] is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will kwargs
surely have embedding
and query
keys?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
- Coverage 84.72% 84.71% -0.01%
==========================================
Files 326 326
Lines 37779 37808 +29
==========================================
+ Hits 32008 32030 +22
- Misses 5771 5778 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges