Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorStore bug fixes #2441

Merged
merged 5 commits into from
Jun 23, 2023
Merged

VectorStore bug fixes #2441

merged 5 commits into from
Jun 23, 2023

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented Jun 20, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  1. Fix user backwards compatibility issue
  2. Fix empty input error and empty embedding function return
  3. Raise exception when both query and embedding are specified

@adolkhan adolkhan changed the title Fixes VectorStore bug fixes Jun 21, 2023
@@ -89,6 +89,11 @@ def parse_search_args(**kwargs):
"Invalid `exec_option` it should be either `python`, `compute_engine` or `tensor_db`."
)

if kwargs["embedding"] is not None and kwargs["query"] is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will kwargs surely have embedding and query keys?

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01 ⚠️

Comparison is base (5f17163) 84.72% compared to head (e2fe991) 84.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
- Coverage   84.72%   84.71%   -0.01%     
==========================================
  Files         326      326              
  Lines       37779    37808      +29     
==========================================
+ Hits        32008    32030      +22     
- Misses       5771     5778       +7     
Flag Coverage Δ
unittests 84.71% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lake/core/vectorstore/test_deeplake_vectorstore.py 68.75% <0.00%> (-0.88%) ⬇️
.../core/vectorstore/vector_search/dataset/dataset.py 97.36% <50.00%> (-0.64%) ⬇️
deeplake/core/vectorstore/vector_search/utils.py 91.44% <50.00%> (-0.56%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adolkhan adolkhan merged commit 3ad2df4 into main Jun 23, 2023
7 of 13 checks passed
@adolkhan adolkhan deleted the ad_vector_store_upd branch June 23, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants