Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-2335] Fixes to .data to make returned results identical to python #2457

Merged
merged 19 commits into from
Jul 20, 2023
Merged

[AL-2335] Fixes to .data to make returned results identical to python #2457

merged 19 commits into from
Jul 20, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Jun 28, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@levongh levongh added the trigger-test Label trigger to run tests on PRs label Jul 5, 2023
@levongh levongh changed the title Data fix [AL-2335] Data fix Jul 13, 2023
@tatevikh tatevikh requested a review from adolkhan July 14, 2023 13:33
@levongh levongh added trigger-test Label trigger to run tests on PRs and removed trigger-test Label trigger to run tests on PRs labels Jul 20, 2023
@levongh levongh merged commit dfb4a8f into main Jul 20, 2023
4 of 7 checks passed
@levongh levongh deleted the data_fix branch July 20, 2023 10:21
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.1% 79.1% Coverage
0.0% 0.0% Duplication

@levongh levongh changed the title [AL-2335] Data fix [AL-2335] Fixes to .data to make returned results identical to python Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farizrahman4u farizrahman4u farizrahman4u approved these changes

@adolkhan adolkhan adolkhan approved these changes

Assignees
No one assigned
Labels
trigger-test Label trigger to run tests on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@levongh @farizrahman4u @adolkhan @tatevikh