Index regeneration on maintenance #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sounakr
changed the title
…fix. Added token missed in merge error.
…m/activeloopai/deeplake into index_regeneration_on_maintenance
nvoxland
approved these changes
Sep 19, 2023
adolkhan
suggested changes
Sep 20, 2023
…m/activeloopai/deeplake into index_regeneration_on_maintenance
…iveloopai/deeplake into index_regeneration_on_maintenance
…e' into index_regeneration_on_maintenance
adolkhan
approved these changes
Sep 21, 2023
istranic
approved these changes
Sep 21, 2023
khustup
approved these changes
Sep 21, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
When vector indexes are created on top of datasets, then any changes to base dataset should be reflected in indexes also. This is done as part of Index maintenance.
Through this PR Index maintenance is implemented and triggered whenever their is a change in base dataset embedding tensor.
Description
This PR regenerates the vector indexes whenever the corresponding embedding tensor in base dataset gets modified.
Things to be aware of
Ideally the index maintenance is a incremental process. But with the starting approach with this PR the index is going to get regenerated which is time consuming.
Things to worry about
This is a slow approach but easy to implement. Taken this strategy as part of initial index maintenance. Improvements will follow for incremental maintenance.