Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast Merge bug fixes #2497

Merged
merged 5 commits into from Jul 27, 2023
Merged

Fast Merge bug fixes #2497

merged 5 commits into from Jul 27, 2023

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Jul 21, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Some bug fixes for fast merge.

@farizrahman4u farizrahman4u changed the title Merge bug fixes Fast Merge bug fixes Jul 21, 2023
@tatevikh tatevikh requested a review from sounakr July 24, 2023 15:08
@FayazRahman FayazRahman added the trigger-test Label trigger to run tests on PRs label Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.02% ⚠️

Comparison is base (48e9073) 84.93% compared to head (407f456) 84.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2497      +/-   ##
==========================================
- Coverage   84.93%   84.91%   -0.02%     
==========================================
  Files         328      328              
  Lines       38800    38818      +18     
==========================================
+ Hits        32955    32963       +8     
- Misses       5845     5855      +10     
Flag Coverage Δ
unittests 84.91% <95.23%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/util/merge.py 93.93% <94.11%> (-1.13%) ⬇️
deeplake/core/chunk_engine.py 93.28% <100.00%> (-0.06%) ⬇️
deeplake/core/dataset/dataset.py 91.74% <100.00%> (+<0.01%) ⬆️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farizrahman4u farizrahman4u merged commit fe1a109 into main Jul 27, 2023
8 of 11 checks passed
@farizrahman4u farizrahman4u deleted the fr_merge_fixes branch July 27, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trigger-test Label trigger to run tests on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants