Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-2358] ignore_errors argument for ds.save_view #2498

Merged
merged 11 commits into from
Jul 25, 2023
Merged

[AL-2358] ignore_errors argument for ds.save_view #2498

merged 11 commits into from
Jul 25, 2023

Conversation

FayazRahman
Copy link
Contributor

馃殌 馃殌 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Specifying ignore_errors=True in ds.save_view will skip any samples that cause errors.
  • Applicable only when optimize=True and in the presence of linked tensors.
  • Normal tensors cannot cause similar errors and does not need ignore_errors.

Things to be aware of

Things to worry about

Additional Context

@FayazRahman FayazRahman merged commit c16b3e5 into main Jul 25, 2023
6 of 9 checks passed
@FayazRahman FayazRahman deleted the fy_save_view_update branch July 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@farizrahman4u farizrahman4u farizrahman4u approved these changes

@adolkhan adolkhan Awaiting requested review from adolkhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FayazRahman @nvoxland @farizrahman4u