Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-2351] Print a transform summary if ignore_errors=True #2503

Merged
merged 3 commits into from
Jul 25, 2023
Merged

[AL-2351] Print a transform summary if ignore_errors=True #2503

merged 3 commits into from
Jul 25, 2023

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Jul 25, 2023 •
edited by nvoxland

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • This PR prints a summary at the end of a transform if ignore_errors=True
  • It will look as such:
No. of samples successfully processed: 16 (80.0%)
No. of samples skipped: 4 (20.0%)

Things to be aware of

Things to worry about

Additional Context

@FayazRahman FayazRahman merged commit 0c6b1b7 into main Jul 25, 2023
6 of 9 checks passed
@FayazRahman FayazRahman deleted the fy_skip_summary branch July 25, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@levongh levongh levongh approved these changes

@farizrahman4u farizrahman4u Awaiting requested review from farizrahman4u

@adolkhan adolkhan Awaiting requested review from adolkhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FayazRahman @nvoxland @levongh