Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2350] Indra returns polygons differently than python #2509

Merged
merged 2 commits into from Aug 1, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Jul 31, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 11.53% and project coverage change: -0.05% ⚠️

Comparison is base (71a391e) 84.91% compared to head (585883d) 84.87%.
Report is 1 commits behind head on exception_if_token_is_empty.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           exception_if_token_is_empty    #2509      +/-   ##
===============================================================
- Coverage                        84.91%   84.87%   -0.05%     
===============================================================
  Files                              328      328              
  Lines                            38820    38843      +23     
===============================================================
+ Hits                             32964    32967       +3     
- Misses                            5856     5876      +20     
Flag Coverage Δ
unittests 84.87% <11.53%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/dataset/deeplake_query_tensor.py 71.29% <0.00%> (ø)
...lake/core/vectorstore/test_deeplake_vectorstore.py 59.91% <ø> (ø)
deeplake/core/tests/test_deeplake_indra_dataset.py 12.36% <12.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levongh levongh changed the title Al 2350 fix [AL-2350] Indra returns polygons differently than python Jul 31, 2023
@levongh levongh changed the base branch from main to exception_if_token_is_empty July 31, 2023 15:00
@levongh levongh merged commit d9a546b into exception_if_token_is_empty Aug 1, 2023
7 of 11 checks passed
@levongh levongh deleted the al_2350_fix branch August 1, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants