Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ternary operator #2514

Merged
merged 2 commits into from Aug 2, 2023
Merged

fix ternary operator #2514

merged 2 commits into from Aug 2, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Aug 2, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@levongh levongh changed the title minor fix ternary operator Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (dbf4c55) 84.87% compared to head (48071ac) 84.89%.

❗ Current head 48071ac differs from pull request most recent head 702139d. Consider uploading reports for the commit 702139d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
+ Coverage   84.87%   84.89%   +0.01%     
==========================================
  Files         328      328              
  Lines       38849    38839      -10     
==========================================
- Hits        32974    32971       -3     
+ Misses       5875     5868       -7     
Flag Coverage Δ
unittests 84.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/tests/test_deeplake_indra_dataset.py 12.07% <ø> (-0.29%) ⬇️
deeplake/enterprise/convert_to_libdeeplake.py 50.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levongh levongh changed the title ternary operator fix ternary operator Aug 2, 2023
@levongh levongh merged commit 1c6db8a into main Aug 2, 2023
5 of 7 checks passed
@levongh levongh deleted the ternar_operator_fix branch August 2, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants