Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec option autocasting fix #2534

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Exec option autocasting fix #2534

merged 3 commits into from
Aug 14, 2023

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented Aug 9, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

There is a bug in auto casting vectorstore, most probably vector_db path changes, and now it is causing a lot of issues on LangChain side

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03% 🎉

Comparison is base (54c6149) 84.87% compared to head (d1fe7a2) 84.90%.

❗ Current head d1fe7a2 differs from pull request most recent head cdf4617. Consider uploading reports for the commit cdf4617 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
+ Coverage   84.87%   84.90%   +0.03%     
==========================================
  Files         328      328              
  Lines       39050    39036      -14     
==========================================
+ Hits        33142    33144       +2     
+ Misses       5908     5892      -16     
Flag Coverage Δ
unittests 84.90% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lake/core/vectorstore/test_deeplake_vectorstore.py 60.29% <0.00%> (-0.13%) ⬇️
deeplake/core/vectorstore/vector_search/utils.py 77.61% <100.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adolkhan adolkhan requested review from FayazRahman, istranic and ProgerDav and removed request for FayazRahman and istranic August 10, 2023 07:30
@adolkhan adolkhan merged commit e1b219e into main Aug 14, 2023
3 of 7 checks passed
@adolkhan adolkhan deleted the exec_option_autocasting_fix branch August 14, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants