Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_tensor(..., exist_ok=True) behavior with htypes #2557

Merged
merged 2 commits into from Aug 29, 2023

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Aug 24, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (daab6b9) 84.91% compared to head (b145fbf) 84.92%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2557   +/-   ##
=======================================
  Coverage   84.91%   84.92%           
=======================================
  Files         328      328           
  Lines       39295    39325   +30     
=======================================
+ Hits        33367    33396   +29     
- Misses       5928     5929    +1     
Flag Coverage Δ
unittests 84.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/api/tests/test_api.py 98.01% <100.00%> (-0.03%) ⬇️
deeplake/core/dataset/dataset.py 91.86% <100.00%> (+0.14%) ⬆️
deeplake/core/transform/test_transform.py 99.11% <100.00%> (-0.20%) ⬇️
deeplake/core/transform/transform.py 96.25% <100.00%> (ø)
deeplake/util/exceptions.py 85.55% <100.00%> (+0.18%) ⬆️
deeplake/util/transform.py 95.40% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FayazRahman FayazRahman merged commit 1d252b0 into main Aug 29, 2023
9 of 11 checks passed
@FayazRahman FayazRahman deleted the fy_fix_exist_ok branch August 29, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] create_tensor(exist_ok=True) breaks for text htypes
4 participants