Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Version Control in Vector Store #2569

Merged
merged 14 commits into from Sep 1, 2023
Merged

Removing Version Control in Vector Store #2569

merged 14 commits into from Sep 1, 2023

Conversation

istranic
Copy link
Contributor

@istranic istranic commented Aug 30, 2023

馃殌 馃殌 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Removing commit from vector store add
  • Removing parameters that are stale

Things to be aware of

  • I left num_workers as a parameter in the initialization, even though it's not used, because we're likely bringing it back, and otherwise, there would be a breaking change with the LangChain integration.
  • Since num_workers and total_samples_processed were removed from add (in order to not minimize stale parameters), they are both specified as 0 when being passed to extend_and_ingest. These parameters are not used and code was temporarily removed form extend_and_ingest
  • This is not super clean, but it's temporary.

Things to worry about

Additional Context

  • Commit was removed because it causes downstream problems and is not supported by Index (for now)

@istranic istranic assigned adolkhan and unassigned adolkhan Aug 30, 2023
@istranic istranic requested a review from adolkhan August 30, 2023 17:46
@istranic istranic merged commit 1260649 into main Sep 1, 2023
7 of 9 checks passed
@istranic istranic deleted the vs_no_versions_2 branch September 1, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants