Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector Srore Memory leak Fix #2570

Merged
merged 3 commits into from Aug 31, 2023
Merged

Vector Srore Memory leak Fix #2570

merged 3 commits into from Aug 31, 2023

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented Aug 31, 2023 •
edited by nvoxland

馃殌 馃殌 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

There was a bug in vectorstore chunk_by_bites algorithms which caused an infinite loop. Fixed it.

Things to be aware of

Things to worry about

Additional Context

@adolkhan adolkhan merged commit 126ded6 into main Aug 31, 2023
6 of 9 checks passed
@adolkhan adolkhan deleted the vectorstore_mem_leak branch August 31, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@levongh levongh levongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adolkhan @nvoxland @levongh