Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added torch batch_sampler #2571

Merged
merged 4 commits into from Sep 1, 2023
Merged

added torch batch_sampler #2571

merged 4 commits into from Sep 1, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Aug 31, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.01% ⚠️

Comparison is base (8771ce5) 84.81% compared to head (f2b6fc7) 84.81%.
Report is 16 commits behind head on main.

❗ Current head f2b6fc7 differs from pull request most recent head c4eb421. Consider uploading reports for the commit c4eb421 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2571      +/-   ##
==========================================
- Coverage   84.81%   84.81%   -0.01%     
==========================================
  Files         330      330              
  Lines       39474    39462      -12     
==========================================
- Hits        33481    33469      -12     
  Misses       5993     5993              
Flag Coverage Δ
unittests 84.81% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/enterprise/dataloader.py 27.42% <33.33%> (+0.15%) ⬆️
deeplake/enterprise/test_pytorch.py 22.54% <42.85%> (+0.25%) ⬆️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikayelh mikayelh self-requested a review September 1, 2023 19:08
@levongh levongh merged commit ca8a4d6 into main Sep 1, 2023
2 of 3 checks passed
@levongh levongh deleted the batch_sampler branch September 1, 2023 19:17
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants