Correctly load chunks with larger headers #2574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
If the header of a chunk is larger than 100 bytes, a
ValueError: buffer size must be a multiple of element size
error was thrown because we only read the first 100 bytes of the chunk and assume the header will fit in it.For performance reasons, this still assumes 100 bytes is all that will be needed, but will now get more data if needed.
Things to be aware of
I couldn't find an better way to test the logic than something more like an end-to-end test
Things to worry about
Nothing