Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .offset parameter to enterprise dataloader #2579

Merged
merged 8 commits into from Sep 6, 2023
Merged

Added .offset parameter to enterprise dataloader #2579

merged 8 commits into from Sep 6, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Sep 5, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  1. Added .offset parameter to enterprise dataloader to give a possibility to continue training from the index where the previous training was stopped
  2. Small sonar fixes

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.06% ⚠️

Comparison is base (5402e20) 83.88% compared to head (c4849ca) 83.83%.
Report is 1 commits behind head on main.

❗ Current head c4849ca differs from pull request most recent head 7ff62dd. Consider uploading reports for the commit 7ff62dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2579      +/-   ##
==========================================
- Coverage   83.88%   83.83%   -0.06%     
==========================================
  Files         224      224              
  Lines       24385    24393       +8     
==========================================
- Hits        20456    20450       -6     
- Misses       3929     3943      +14     
Flag Coverage Δ
unittests 83.83% <84.61%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/auto/structured/dataframe.py 95.00% <ø> (ø)
deeplake/core/compression.py 77.55% <ø> (+0.07%) ⬆️
deeplake/core/dataset/dataset.py 92.79% <ø> (-0.06%) ⬇️
deeplake/core/transform/transform.py 96.27% <ø> (ø)
deeplake/core/tensor.py 87.28% <33.33%> (ø)
deeplake/enterprise/dataloader.py 80.70% <90.00%> (+0.10%) ⬆️
deeplake/enterprise/convert_to_libdeeplake.py 61.53% <100.00%> (-0.37%) ⬇️
deeplake/enterprise/libdeeplake_query.py 97.14% <100.00%> (-0.08%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levongh levongh changed the title add offset Added .offset parameter to enterprise dataloader Sep 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

31.0% 31.0% Coverage
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@levongh levongh merged commit 1169406 into main Sep 6, 2023
10 of 11 checks passed
@levongh levongh deleted the add_offset branch September 6, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants