Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check indra availability #2592

Merged
merged 2 commits into from Sep 11, 2023
Merged

check indra availability #2592

merged 2 commits into from Sep 11, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Sep 11, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.60% ⚠️

Comparison is base (ec5446e) 83.97% compared to head (58193bd) 83.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
- Coverage   83.97%   83.37%   -0.60%     
==========================================
  Files         224      224              
  Lines       24573    24573              
==========================================
- Hits        20634    20488     -146     
- Misses       3939     4085     +146     
Flag Coverage Δ
unittests 83.37% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Test by default with 3.11
@nvoxland
Copy link
Contributor

nvoxland commented Sep 11, 2023

I switching the default testing to 3.11 to make sure there are no failures. That can be temporary or we can keep it permanent. Discussing...

I also fixed a spelling error in libdeeplake_available()

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@levongh levongh merged commit 313540e into main Sep 11, 2023
13 of 14 checks passed
@levongh levongh deleted the libdeeplake_available branch September 11, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants