Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default embedding htype to float32 #2595

Merged
merged 3 commits into from Sep 19, 2023
Merged

Set default embedding htype to float32 #2595

merged 3 commits into from Sep 19, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -4.71% ⚠️

Comparison is base (e7cec8d) 83.99% compared to head (646b983) 79.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   83.99%   79.28%   -4.71%     
==========================================
  Files         224      224              
  Lines       24674    24674              
==========================================
- Hits        20725    19563    -1162     
- Misses       3949     5111    +1162     
Flag Coverage Δ
unittests 79.28% <ø> (-4.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@FayazRahman FayazRahman merged commit 02664a2 into main Sep 19, 2023
11 of 14 checks passed
@FayazRahman FayazRahman deleted the fy_emb_htype branch September 19, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants