Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed typing_extensions usage #2610

Merged
merged 1 commit into from Sep 22, 2023
Merged

Removed typing_extensions usage #2610

merged 1 commit into from Sep 22, 2023

Conversation

nvoxland
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

typing_extensions should not be a dependency of deeplake, and no need to add it.

With the current code, unless a user manually installs typing_extensions, they get the error:

File ~/Documents/code/activeloop_index/deeplake/deeplake/util/path.py:5
      2 import posixpath
      3 from typing import Optional, Union, Tuple, Dict
----> 5 from typing_extensions import LiteralString
      7 from deeplake.core.storage.provider import StorageProvider
      8 from deeplake.util.tag import process_hub_path

ModuleNotFoundError: No module named 'typing_extensions'

Things to be aware of

Things to worry about

Additional Context

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.60% ⚠️

Comparison is base (78b60e3) 84.01% compared to head (618f70f) 83.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
- Coverage   84.01%   83.41%   -0.60%     
==========================================
  Files         224      224              
  Lines       24674    24673       -1     
==========================================
- Hits        20729    20582     -147     
- Misses       3945     4091     +146     
Flag Coverage Δ
unittests 83.41% <100.00%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/util/path.py 94.25% <100.00%> (-0.07%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatevikh tatevikh merged commit 6326dd2 into main Sep 22, 2023
13 of 14 checks passed
@tatevikh tatevikh deleted the remove_typing_extensions branch September 22, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants