Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to lz4 block. #2657

Merged
merged 1 commit into from Oct 16, 2023
Merged

Switch to lz4 block. #2657

merged 1 commit into from Oct 16, 2023

Conversation

khustup
Copy link
Contributor

@khustup khustup commented Oct 15, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ab62dff) 84.27% compared to head (cf9f8ac) 83.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
- Coverage   84.27%   83.70%   -0.57%     
==========================================
  Files         229      229              
  Lines       25528    25528              
==========================================
- Hits        21513    21369     -144     
- Misses       4015     4159     +144     
Flag Coverage Δ
unittests 83.70% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
deeplake/core/compression.py 78.04% <100.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@khustup khustup merged commit aaaadca into main Oct 16, 2023
13 of 14 checks passed
@khustup khustup deleted the lz4-block branch October 16, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants