Deep memory fixes #2662

adolkhan · 2023-10-17T18:35:28Z

🚀 🚀 Pull Request

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Instead of sequentially computing recall at each score during evaluation, now we do it once for 100 samples, and deduce all other recalls from that

Things to be aware of

Things to worry about

Additional Context

codecov · 2023-10-17T19:43:34Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (16f051c) 84.33% compared to head (0ea5ab6) 84.35%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2662      +/-   ##
==========================================
+ Coverage   84.33%   84.35%   +0.01%     
==========================================
  Files         229      230       +1     
  Lines       25577    25634      +57     
==========================================
+ Hits        21571    21624      +53     
- Misses       4006     4010       +4

Flag	Coverage Δ
unittests	`84.35% <97.22%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
deeplake/client/utils.py	`90.24% <ø> (-0.15%)`	⬇️
deeplake/core/vectorstore/deeplake_vectorstore.py	`96.96% <100.00%> (+0.02%)`	⬆️
...core/vectorstore/vector_search/dataset/__init__.py	`100.00% <ø> (ø)`
deeplake/core/vectorstore/deep_memory.py	`94.17% <97.22%> (+0.25%)`	⬆️
deeplake/core/vectorstore/embedder.py	`98.57% <98.57%> (ø)`
deeplake/core/vectorstore/vector_search/utils.py	`96.23% <97.67%> (+0.06%)`	⬆️
.../core/vectorstore/vector_search/dataset/dataset.py	`97.60% <93.10%> (-0.85%)`	⬇️