Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag htype #2676

Merged
merged 13 commits into from Dec 1, 2023
Merged

Tag htype #2676

merged 13 commits into from Dec 1, 2023

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Nov 2, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • We need a special htype for tagging samples (small strings) that are used for search and not for training.
  • We don't want to use class_label because there's no need to encode the tags as numbers and the htype's name is not intuitive.
  • We don't want to use text or json because these htypes need to support large amounts of information in comparison to tags, and visualizer needs to display both of these differently.

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7b84efb) 84.37% compared to head (6fa0be3) 83.81%.

Files Patch % Lines
deeplake/integrations/pytorch/common.py 40.00% 6 Missing ⚠️
deeplake/util/htype.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2676      +/-   ##
==========================================
- Coverage   84.37%   83.81%   -0.56%     
==========================================
  Files         231      231              
  Lines       25902    25914      +12     
==========================================
- Hits        21854    21720     -134     
- Misses       4048     4194     +146     
Flag Coverage Δ
unittests 83.81% <75.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adolkhan
Copy link
Contributor

I do get all of the changes, but I don't get bigger picture, why do we need tag htype? From what I am seeing it is the same text htype but with a different name. If there is a specific reason on why we need it, maybe then it would be a better idea to create a base class for the htypes that are string?

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.4% 77.4% Coverage
0.0% 0.0% Duplication

@FayazRahman FayazRahman merged commit edf06d7 into main Dec 1, 2023
10 of 13 checks passed
@FayazRahman FayazRahman deleted the fy_tag branch December 1, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants