change libdeeplake error message #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levongh
changed the title
levongh
changed the title
istranic
suggested changes
Nov 3, 2023
deeplake/enterprise/util.py
Outdated
| "This feature requires the libdeeplake package which can be installed using pip install deeplake[enterprise]. libdeeplake is available only on linux for python versions 3.6 through 3.10 and on macos for python versions 3.7 through 3.11" | ||
| ) | ||
| if os.name == 'nt': | ||
| raise ImportError("High performance features are requiring the libdeeplake package which is not available in Windows OS") |
There was a problem hiding this comment.
"are requiring" -> "require"
deeplake/enterprise/util.py
Outdated
| raise ImportError("High performance features are requiring the libdeeplake package which is not available in Windows OS") | ||
| else: | ||
| raise ImportError( | ||
| "High performance features are requiring the libdeeplake package which can be installed using pip install libdeeplake." |
There was a problem hiding this comment.
High performance features require the libdeeplake package. This package in typically installed by default, and you may install it separately using pip install libdeeplake.
istranic
approved these changes
Nov 3, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
==========================================
- Coverage 84.26% 83.70% -0.56%
==========================================
Files 231 231
Lines 25840 25843 +3
==========================================
- Hits 21773 21632 -141
- Misses 4067 4211 +144
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
khustup
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context