Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] minor fix for parsing params in ingest_dataframe #2683

Merged
merged 3 commits into from Nov 9, 2023

Conversation

istranic
Copy link
Contributor

@istranic istranic commented Nov 3, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

-- Fixed minor bug when specifying custom column params in ingest dataframe

Things to be aware of

Things to worry about

Additional Context

@istranic istranic changed the title minor fix for parsing params [BUGFIX] minor fix for parsing params in ingest_dataframe Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fce0d9f) 84.24% compared to head (4cbbc1e) 83.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
- Coverage   84.24%   83.07%   -1.18%     
==========================================
  Files         231      231              
  Lines       25856    25849       -7     
==========================================
- Hits        21783    21474     -309     
- Misses       4073     4375     +302     
Flag Coverage Δ
unittests 83.07% <100.00%> (-1.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
deeplake/auto/structured/dataframe.py 93.15% <100.00%> (-1.85%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@istranic istranic merged commit 430c96e into main Nov 9, 2023
9 of 14 checks passed
@istranic istranic deleted the fix_ingest_dataframe branch November 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants