Avoid VDB Index copy with 'like' API #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
==========================================
- Coverage 84.37% 83.82% -0.55%
==========================================
Files 231 231
Lines 25902 25904 +2
==========================================
- Hits 21854 21715 -139
- Misses 4048 4189 +141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FayazRahman
approved these changes
Nov 14, 2023
adolkhan
reviewed
Nov 14, 2023
deeplake/core/tensor.py
Outdated
| @@ -350,9 +350,10 @@ def extend( | |||
| Raises: | |||
| TensorDtypeMismatchError: Dtype for array must be equal to or castable to this tensor's dtype. | |||
| """ | |||
| old_dataset_length = self.num_samples | |||
There was a problem hiding this comment.
is this change really necessary?
There was a problem hiding this comment.
Yes, in order to keep track of the initial records.
nvoxland
approved these changes
Nov 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
nvoxland-al
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Deeplake Like No samples are copied, only the meta/info for the dataset and it’s tensors. But Like shouldn't copy the vdb index information from the tensor meta to the destination tensor. As currently the vdb index can only be created from vector store Init with the Index Parameters passed through it.
Impact
Description
Things to be aware of
Things to worry about
Additional Context