Removed pip install deeplake[enterprise] references in docs #2688
Conversation
| @@ -4764,7 +4763,6 @@ def max_view(self): | |||
| def random_split(self, lengths: Sequence[Union[int, float]]): | |||
| """Splits the dataset into non-overlapping :class:`~deeplake.core.dataset.Dataset` objects of given lengths. | |||
| If a list of fractions that sum up to 1 is given, the lengths will be computed automatically as floor(frac * len(dataset)) for each fraction provided. | |||
| The split generated is only performant with enterprise dataloader which can be installed with ``pip install deeplake[enterprise]``. | |||
There was a problem hiding this comment.
We should say: This feature is only compatible with the high-performance dataloader.
I asked @levongh to figure out what happens when this is used with OSS dataloader. I'm honestly not sure.
| @@ -398,7 +398,7 @@ def evaluate( | |||
|
|
|||
| if not INDRA_INSTALLED: | |||
| raise ImportError( | |||
| "indra is not installed. Please install indra to use this functionality with: pip install `deeplake[enterprise]`" | |||
| "The C++ library is not installed." | |||
There was a problem hiding this comment.
We should add. 'The library should be installed using pip install deeplake, but if you want to install it separately, you may run pip install libdeeplake.'
There was a problem hiding this comment.
Updated this, take a look now
| @@ -99,7 +99,7 @@ def dataset_to_pytorch( | |||
| for t in tensors: | |||
| if dataset[t].is_sequence: | |||
| raise NotImplementedError( | |||
| f"Deep Lake’s OSS pure-python dataloader is not compatible with tensor `{t}` with htype = sequence[…]. Please use the C++ dataloader via ds.dataloader(…), which can be installed using ‘pip install deeplake[enterprise]’." | |||
| f"Deep Lake’s OSS pure-python dataloader is not compatible with tensor `{t}` with htype = sequence[…]. Please use the C++ dataloader via ds.dataloader(…)" | |||
There was a problem hiding this comment.
Instead of C++ dataloader, let's say 'high-performance dataloader'. That's consistent with language Levon is using in indra
There was a problem hiding this comment.
Yeah, I like that better than mentioning the language. Users don't care what we implement it in
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
===========================================
- Coverage 84.24% 71.90% -12.35%
===========================================
Files 231 231
Lines 25856 25856
===========================================
- Hits 21783 18592 -3191
- Misses 4073 7264 +3191
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
🚀 🚀 Pull Request
Impact
Description
No need to pip install deeplake[enterprise] anymore, so removed references to it.
Things to worry about
Did a search in this repo for 'deeplake[enterprise]" . Is there other places that need to be changed that got missed?