New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deepmemory ux improvements #2710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdkSarsen
force-pushed
the
deepmemory_ux_improvements
branch
from
November 30, 2023 15:24
f982aa8
to
afd1264
Compare
AdkSarsen
added
quick-tests
Run DeepLake quick tests
and removed
full-tests
Trigger Full versioned OS tests
labels
Dec 5, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 84.42% 81.83% -2.59%
==========================================
Files 233 233
Lines 26099 26177 +78
==========================================
- Hits 22034 21422 -612
- Misses 4065 4755 +690
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AdkSarsen
force-pushed
the
deepmemory_ux_improvements
branch
from
December 5, 2023 11:27
03d286b
to
1269ea9
Compare
taylorstubbsactiveloop
approved these changes
Dec 5, 2023
taylorstubbsactiveloop
approved these changes
Dec 5, 2023
taylorstubbsactiveloop
approved these changes
Dec 6, 2023
Kudos, SonarCloud Quality Gate passed! |
khustup2
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
In the PR I am doing the following changes:
set_model
andget_model
for deep_memory. Now you can choose the deepmemory model, among the trained models and can register it so that in all subsequent load, searches we use registered model. This is done by overwriting model.npy from default one to the one you choose in the dataset.embedding.info. Following tests, test the behavior:test_deepmemory_v2_set_model_should_set_model_for_all_subsequent_loads
tensor_db
is used then search goes through managed db, and ifcompute_engine
is used then search is going through local indra.SearchIndra
andSearchManaged
instead of doing everything in a single method.local_dmv2_dataset
path fixture that contains a dataset with deepmemory v2 model.Things to be aware of
Things to worry about
Additional Context