Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepmemory ux improvements #2710

Merged
merged 18 commits into from Dec 8, 2023
Merged

Deepmemory ux improvements #2710

merged 18 commits into from Dec 8, 2023

Conversation

AdkSarsen
Copy link
Contributor

@AdkSarsen AdkSarsen commented Nov 30, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In the PR I am doing the following changes:

  • Adding support for set_model and get_model for deep_memory. Now you can choose the deepmemory model, among the trained models and can register it so that in all subsequent load, searches we use registered model. This is done by overwriting model.npy from default one to the one you choose in the dataset.embedding.info. Following tests, test the behavior: test_deepmemory_v2_set_model_should_set_model_for_all_subsequent_loads
  • Adding ability to pass directly dataset together with path to the DeepMemory class, this is done to not to reinstantiate the deeplake dataset
  • Adding support to return tql query generated during search. This is useful for future tests, where we would want to ensure that the generated tql is correct
  • Adding interaction tests to ensure that if tensor_db is used then search goes through managed db, and if compute_engine is used then search is going through local indra.
  • Also adding some code refactoring to make sure that previous point works as expected. Created 2 new classes, called SearchIndra and SearchManaged instead of doing everything in a single method.
  • Adding local_dmv2_dataset path fixture that contains a dataset with deepmemory v2 model.

Things to be aware of

Things to worry about

Additional Context

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@AdkSarsen AdkSarsen marked this pull request as draft November 30, 2023 10:53
@AdkSarsen AdkSarsen marked this pull request as ready for review November 30, 2023 12:58
@AdkSarsen AdkSarsen added the full-tests Trigger Full versioned OS tests label Nov 30, 2023
@AdkSarsen AdkSarsen added quick-tests Run DeepLake quick tests and removed full-tests Trigger Full versioned OS tests labels Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2142ee4) 84.42% compared to head (056bead) 81.83%.

Files Patch % Lines
...ectorstore/vector_search/indra/search_algorithm.py 91.17% 6 Missing ⚠️
...eplake/core/vectorstore/deep_memory/deep_memory.py 96.77% 1 Missing ⚠️
.../vectorstore/vector_search/python/vector_search.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2710      +/-   ##
==========================================
- Coverage   84.42%   81.83%   -2.59%     
==========================================
  Files         233      233              
  Lines       26099    26177      +78     
==========================================
- Hits        22034    21422     -612     
- Misses       4065     4755     +690     
Flag Coverage Δ
unittests 81.83% <94.20%> (-2.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdkSarsen AdkSarsen removed the quick-tests Run DeepLake quick tests label Dec 5, 2023
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

94.2% 94.2% Coverage
0.0% 0.0% Duplication

@AdkSarsen AdkSarsen merged commit 5131bc6 into main Dec 8, 2023
9 of 13 checks passed
@AdkSarsen AdkSarsen deleted the deepmemory_ux_improvements branch December 8, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants