Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cached chunks from dataset pickle #2711

Merged
merged 5 commits into from Dec 5, 2023
Merged

Remove cached chunks from dataset pickle #2711

merged 5 commits into from Dec 5, 2023

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Nov 30, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Cached chunks should not be present in the serialized dataset
  • Set these attributes to None in the ChunkEngine before returning the state in __getstate__

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba57790) 84.43% compared to head (4fc7eca) 83.86%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
- Coverage   84.43%   83.86%   -0.57%     
==========================================
  Files         233      233              
  Lines       26064    26087      +23     
==========================================
- Hits        22007    21879     -128     
- Misses       4057     4208     +151     
Flag Coverage Δ
unittests 83.86% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deeplake/api/tests/test_pickle.py Outdated Show resolved Hide resolved
deeplake/api/tests/test_pickle.py Outdated Show resolved Hide resolved
FayazRahman and others added 3 commits December 1, 2023 15:40
Co-authored-by: AdkSarsen <151118576+AdkSarsen@users.noreply.github.com>
Co-authored-by: AdkSarsen <151118576+AdkSarsen@users.noreply.github.com>
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@FayazRahman FayazRahman merged commit 2142ee4 into main Dec 5, 2023
11 of 13 checks passed
@FayazRahman FayazRahman deleted the fy_pkl_fix branch December 5, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants