Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ds.summary #2714

Merged
merged 2 commits into from Dec 15, 2023
Merged

Fix ds.summary #2714

merged 2 commits into from Dec 15, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • np.dtype('float64') compares equal to None so the summary was wrong.
  • Compare with is instead.

Things to be aware of

Things to worry about

Additional Context

@FayazRahman FayazRahman changed the title fix Fix ds.summary Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edf06d7) 84.42% compared to head (39ae042) 83.83%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2714      +/-   ##
==========================================
- Coverage   84.42%   83.83%   -0.59%     
==========================================
  Files         233      233              
  Lines       26092    26099       +7     
==========================================
- Hits        22028    21880     -148     
- Misses       4064     4219     +155     
Flag Coverage Δ
unittests 83.83% <100.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 12, 2023

@FayazRahman FayazRahman merged commit 04e4490 into main Dec 15, 2023
12 of 13 checks passed
@FayazRahman FayazRahman deleted the fy_fix_sum branch December 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants