Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepmemory refactoring #2717

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Deepmemory refactoring #2717

wants to merge 9 commits into from

Conversation

AdkSarsen
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (2142ee4) 84.42% compared to head (d6530b9) 81.65%.

Files Patch % Lines
.../core/vectorstore/dev_helpers/vectorstore_tools.py 0.00% 42 Missing ⚠️
...eplake/core/vectorstore/deep_memory/deep_memory.py 86.07% 33 Missing ⚠️
...ectorstore/vector_search/indra/search_algorithm.py 89.70% 7 Missing ⚠️
.../vectorstore/vector_search/python/vector_search.py 50.00% 1 Missing ⚠️
deeplake/util/exceptions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2717      +/-   ##
==========================================
- Coverage   84.42%   81.65%   -2.77%     
==========================================
  Files         233      234       +1     
  Lines       26099    26274     +175     
==========================================
- Hits        22034    21454     -580     
- Misses       4065     4820     +755     
Flag Coverage Δ
unittests 81.65% <77.11%> (-2.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

75.2% 75.2% Coverage
0.0% 0.0% Duplication

@AdkSarsen AdkSarsen marked this pull request as draft December 6, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant