Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster import #2728

Merged
merged 2 commits into from Jan 4, 2024
Merged

Faster import #2728

merged 2 commits into from Jan 4, 2024

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Defer import of optional libraries to respective class methods to speed up import deeplake

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (b730cad) 84.38% compared to head (f78e263) 83.26%.
Report is 70 commits behind head on main.

Files Patch % Lines
deeplake/util/object_3d/ply_readers.py 54.54% 5 Missing ⚠️
deeplake/util/transform.py 50.00% 4 Missing ⚠️
deeplake/core/compression.py 80.00% 3 Missing ⚠️
deeplake/core/storage/gcs.py 86.66% 2 Missing ⚠️
deeplake/core/storage/google_drive.py 84.61% 2 Missing ⚠️
deeplake/enterprise/dummy_dataloader.py 0.00% 2 Missing ⚠️
deeplake/core/storage/azure.py 92.85% 1 Missing ⚠️
...ectorstore/vector_search/indra/search_algorithm.py 50.00% 1 Missing ⚠️
deeplake/core/vectorstore/vector_search/utils.py 0.00% 1 Missing ⚠️
deeplake/util/object_3d/read_3d_data.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   84.38%   83.26%   -1.12%     
==========================================
  Files         233      233              
  Lines       26216    26219       +3     
==========================================
- Hits        22122    21831     -291     
- Misses       4094     4388     +294     
Flag Coverage Δ
unittests 83.26% <75.28%> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 29, 2023

@FayazRahman FayazRahman merged commit 8582788 into main Jan 4, 2024
7 of 12 checks passed
@FayazRahman FayazRahman deleted the fy_faster_import branch January 4, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants