Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 changes, Indra adaptors #2733

Merged
merged 88 commits into from
Apr 4, 2024
Merged

V4 changes, Indra adaptors #2733

merged 88 commits into from
Apr 4, 2024

Conversation

khustup2
Copy link
Contributor

@khustup2 khustup2 commented Jan 5, 2024

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Cleanup indra dataset and tensor views, avoid usage of deeplake_ds there.
  • Introduce storage.indra.IndraProvider as a generic storage provider from indra
  • Introduce indra: bool argument to api functions deeplake.load, deeplake.emtpy etc. To use indra storage and read_only views under the hood.

Things to be aware of

Things to worry about

There's no big impact for now, as indra argument is by default False, but we need to test the whole functionality with indra=True

Additional Context

@khustup2 khustup2 marked this pull request as ready for review February 13, 2024 12:39
Copy link

codecov bot commented Feb 13, 2024

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ khustup2
✅ khustup
❌ zaaram
You have signed the CLA already but the status is still pending? Let us recheck it.

@nvoxland-al nvoxland-al merged commit e75c56c into main Apr 4, 2024
8 of 12 checks passed
@nvoxland-al nvoxland-al deleted the v4 branch April 4, 2024 21:54
Copy link

sonarcloud bot commented Apr 4, 2024

khustup2 added a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants