Ensure filename remains set for later saving in sample_info

[nvoxland-al]

🚀 🚀 Pull Request

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

When a new image is added and it does not fit in a sample compressed chunk, the filename gets lots from the sample_info.

This ensures the filename remains set on the Sample object for later use by the sample_info tensor

Things to be aware of

We had to remove the logic from sample.py that uses the path as the compressed data if it exists now that we're better setting the path. No tests are failing from the change, so it seems like a needed change to that code

Things to worry about

Nothing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac1c471) 84.50% compared to head (0abc327) 79.22%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
- Coverage   84.50%   79.22%   -5.28%     
==========================================
  Files         233      233              
  Lines       26458    26459       +1     
==========================================
- Hits        22358    20963    -1395     
- Misses       4100     5496    +1396     

Flag	Coverage Δ
unittests	79.22% <100.00%> (-5.28%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud