Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable downloading docs #2753

Merged
merged 10 commits into from Jan 31, 2024
Merged

Enable downloading docs #2753

merged 10 commits into from Jan 31, 2024

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Enable downloading the docs in epub and pdf formats.

Things to be aware of

Things to worry about

Additional Context

@istranical istranical self-requested a review January 26, 2024 18:22
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (763f7c0) 80.10% compared to head (c5ee4ae) 83.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2753      +/-   ##
==========================================
+ Coverage   80.10%   83.63%   +3.53%     
==========================================
  Files         233      233              
  Lines       26461    26461              
==========================================
+ Hits        21196    22131     +935     
+ Misses       5265     4330     -935     
Flag Coverage Δ
unittests 83.63% <ø> (+3.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@FayazRahman FayazRahman merged commit 541fb4c into main Jan 31, 2024
12 checks passed
@FayazRahman FayazRahman deleted the fy_doc_dl branch January 31, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants