Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Deeplake CLI #2761

Merged
merged 3 commits into from Feb 6, 2024
Merged

Removed Deeplake CLI #2761

merged 3 commits into from Feb 6, 2024

Conversation

nvoxland-al
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The CLI does not have a lot of uses or many users, so we are removing it from the library. All functionality previously in the CLI continues to be available through the python API

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85c5185) 84.36% compared to head (907ff52) 83.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
- Coverage   84.36%   83.89%   -0.47%     
==========================================
  Files         233      231       -2     
  Lines       26543    26434     -109     
==========================================
- Hits        22393    22177     -216     
- Misses       4150     4257     +107     
Flag Coverage Δ
unittests 83.89% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nvoxland-al nvoxland-al merged commit 9fbdcba into main Feb 6, 2024
11 of 12 checks passed
@nvoxland-al nvoxland-al deleted the remove-cli branch February 6, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants