Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed edge cases in indra dataset adaptor. #2762

Merged
merged 1 commit into from Feb 4, 2024
Merged

Fixed edge cases in indra dataset adaptor. #2762

merged 1 commit into from Feb 4, 2024

Conversation

khustup2
Copy link
Contributor

@khustup2 khustup2 commented Feb 4, 2024

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (85c5185) 84.36% compared to head (a55a4a2) 83.79%.
Report is 1 commits behind head on main.

Files Patch % Lines
deeplake/core/dataset/deeplake_query_dataset.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
- Coverage   84.36%   83.79%   -0.57%     
==========================================
  Files         233      233              
  Lines       26543    26548       +5     
==========================================
- Hits        22393    22247     -146     
- Misses       4150     4301     +151     
Flag Coverage Δ
unittests 83.79% <80.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 4, 2024

@khustup2 khustup2 merged commit aeac9c7 into main Feb 4, 2024
10 of 12 checks passed
@khustup2 khustup2 deleted the indra-fix branch February 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants