Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upcasting logic #2773

Merged
merged 1 commit into from Feb 16, 2024
Merged

fix upcasting logic #2773

merged 1 commit into from Feb 16, 2024

Conversation

activesoull
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Copy link

sonarcloud bot commented Feb 16, 2024

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fff66c) 84.41% compared to head (ca29e9c) 83.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   84.41%   83.87%   -0.54%     
==========================================
  Files         231      231              
  Lines       26437    26440       +3     
==========================================
- Hits        22316    22176     -140     
- Misses       4121     4264     +143     
Flag Coverage Δ
unittests 83.87% <100.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@activesoull activesoull merged commit a906532 into main Feb 16, 2024
11 of 12 checks passed
@activesoull activesoull deleted the upcasting_logic_fix branch February 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants