Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require azure modules to be installed #2803

Merged
merged 2 commits into from Mar 20, 2024
Merged

Conversation

nvoxland-al
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

3.8.26 incorrectly assumed azure is installed. It is only available with pip install deeplake[azure]

This PR makes the import only happen on functionality use

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.89%. Comparing base (c72b445) to head (ae9bc00).
Report is 1 commits behind head on main.

Files Patch % Lines
deeplake/client/auth/azure.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
- Coverage   84.47%   83.89%   -0.59%     
==========================================
  Files         235      235              
  Lines       26527    26533       +6     
==========================================
- Hits        22409    22260     -149     
- Misses       4118     4273     +155     
Flag Coverage Δ
unittests 83.89% <57.14%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 20, 2024

@nvoxland-al nvoxland-al merged commit a05817d into main Mar 20, 2024
8 of 12 checks passed
@nvoxland-al nvoxland-al deleted the fix_azure_import branch March 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants