Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage temp tensor files in memory rather than sending them to storage #2819

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nvoxland-al
Copy link
Contributor

馃殌 馃殌 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

With a large number of temp tensors, the on-disk metadata management gets time consuming. This PR avoids the overhead by keeping them in-memory.

Things to be aware of

Does not attempt to limit the temp tensor cache, but they are currently only used for class_labels which will not be large amounts of data

@nvoxland-al
Copy link
Contributor Author

Currently does not work with scheduler=processed. Going to get feedback before looking at handling that better.

@nvoxland-al nvoxland-al marked this pull request as ready for review April 4, 2024 19:59
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 96.03175% with 5 lines in your changes are missing coverage. Please review.

Files Patch % Lines
deeplake/core/storage/provider.py 94.44% 3 Missing 鈿狅笍
deeplake/core/storage/local.py 92.30% 1 Missing 鈿狅笍
deeplake/core/storage/lru_cache.py 90.90% 1 Missing 鈿狅笍

馃摙 Thoughts on this report? Let us know!

Copy link

sonarcloud bot commented Apr 12, 2024

@nvoxland-al nvoxland-al marked this pull request as draft April 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants