-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Filtering #460
Merged
Merged
Dataset Filtering #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/filtering
Feature/filtering
Locust summaryGit referencesInitial: ace631fTerminal: 9d5db62 hub/api/tensorview.pyChanges:
hub/api/datasetview.pyChanges:
hub/api/dataset.pyChanges:
hub/api/objectview.pyChanges:
hub/compute/transform.pyChanges:
hub/store/dynamic_tensor.pyChanges:
hub/compute/ray.pyChanges:
hub/exceptions.pyChanges:
hub/store/shape_detector.pyChanges:
hub/api/tests/test_dataset.pyChanges:
hub/api/tests/test_objectview.pyChanges:
hub/api/tests/test_tensorview.pyChanges:
hub/utils.pyChanges:
|
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
+ Coverage 88.20% 88.29% +0.08%
==========================================
Files 50 52 +2
Lines 3664 3724 +60
==========================================
+ Hits 3232 3288 +56
- Misses 432 436 +4
Continue to review full report at Codecov.
|
edogrigqv2
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filtering to datasets using a dictionary as a filter. Changes underlying implementation of datasetview and tensorview for the same, API remains the same as before.
Filtering can only be applied for keys that have product of max_shape less than 100.
Example usage:-